Skip to content

Fixed DFPlayer init issue #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nk25719 merged 2 commits into from
Mar 23, 2026
Merged

Fixed DFPlayer init issue #412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7353ea2
Fixed DFPlayer init issue
Yukti007 Mar 21, 2026
2106394
re-enable DFPlayer ACK mode after begin() to prevent intermittent fal…
Yukti007 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Firmware/factoryTest/FactoryTest_wMenu/FactoryTest_wMenu.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#define DEVICE_UNDER_TEST "SN: LB0008" //A Serial Number
#define PROG_NAME "FactoryTest_wMenu"
#define FIRMWARE_VERSION "v0.4.5.0"
#define FIRMWARE_VERSION "v0.4.5.1"
/*
------------------------------------------------------------------------------
File: FactoryTest_wMenu.ino
Project: Krake / GPAD v2 – Factory Test Firmware
Document Type: Source Code (Factory Test)
Document ID: KRAKE-FT-ESP32-FT01
Version: v0.4.5.0
Version: v0.4.5.1
Date: 2026-03-17
Author(s): Nagham Kheir, Public Invention
Status: Draft
Expand Down Expand Up @@ -52,11 +52,12 @@ Revision History:
|v0.4.4.1 | 2026-3-18 | Yukti | Added automatic Wifi Testing inside OTA test |
|v0.4.5.0 | 2026-3-17 | Yukti | Add T_MUTE_BTN test (key F): tests S601 mute |
| | | | push button GPIO and LED_Status toggle. |
| | | | Uses OneButton for press-duration handling: |
| | | | Uses OneButton for press-duration handling: |
| | | | too-short ignored, too-long warns operator. |
| | | | active-LOW, external pull-up R603, hardware |
| | | | RC debounce C602 on PCB. internalPullup=false. |
| | | | Requires: OneButton lib from Library Manager. |
|v0.4.5.1 | 2026-3-23 | Yukti | Fixed DFPlayer ACK handling |
----------------------------------------------------------------------------------------|
Overview:
- Repeatable factory test sequence for ESP32-WROOM-32D Krake/GPAD v2 boards.
Expand Down Expand Up @@ -724,13 +725,14 @@ static bool initDFPlayer() {
dfSerial.begin(9600, SERIAL_8N1, DF_RXD2, DF_TXD2);
delay(300);

if (!dfPlayer.begin(dfSerial, true, true)) {
if (!dfPlayer.begin(dfSerial, false, true)) {
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Re-enable ACK after the DFPlayer init workaround

Passing false here changes more than the startup check: in DFRobotDFPlayerMini, begin(..., false, ...) disables ACK mode on the dfPlayer object for all later commands. In this sketch that means outputDevice() in initDFPlayer() and the volume()/play()/stop() sequence in runTest_Speaker() no longer wait for the module's command ACKs and instead run with only the library's fixed 10 ms pacing. On slower DFPlayers or SD cards this can turn tests 5/6 into intermittent false FAILs even after init succeeds, so the workaround should not leave ACKs disabled for the rest of the session.

Useful? React with 👍 / 👎.

Serial.println(F("DFPlayer not detected (begin failed)."));
dfState = DF_FAIL;
return false;
}

dfPlayer.setTimeOut(1000);
dfPlayer.enableACK(); // ← restore ACK for the rest of the session
dfPlayer.outputDevice(DFPLAYER_DEVICE_SD);
delay(1200);

Expand Down