fix: windows server 2019 activation failing because of incomplete entry in KmsDataBase.xml#143
Merged
simonmicro merged 2 commits intoPy-KMS-Organization:nextfrom Apr 17, 2026
Conversation
in KmsDataBase.xml
Rileran
force-pushed
the
fix/windows-server-2019
branch
from
92f904b to
ecf50e0
Compare
MrRubberDucky
added a commit
to Rubberverse/qor-kms
that referenced
this pull request
Feb 26, 2026
this totally will go well and won't break everything. Signed-off-by: Mr. Rubber Ducky <79613254+MrRubberDucky@users.noreply.github.com>
Member
|
Ah, I found the base-branch button again after the UI change by Github. Lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #138, where Windows Server 2019 would not work because of an entry in KmsDataBase.xml.
The entry for Windows Server 2019 (Azure Only) is missing MinKeyId and MaxKeyId which are required for pykms to compute the pid.
What this PR does is ignoring any invalid entries in the XML file, preventing the pid_generator from not returning when other valid entries exists.