Removes django-html-sanitizer django-braces and bleach#598
Open
eduzen wants to merge 5 commits intoPyAr:masterfrom
Open
Removes django-html-sanitizer django-braces and bleach#598eduzen wants to merge 5 commits intoPyAr:masterfrom
eduzen wants to merge 5 commits intoPyAr:masterfrom
Conversation
…dency and implement custom sanitizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bueno, la idea es actualizar Django y algunas dependencias, pero el proyecto estaba usando unas librerías abandonadas para sanitizar inputs con HTML.
Asi que usando un poco de beatifulsoap saque
django-html-sanitizer(ultimo commit hace 10 años: https://github.com/ui/django-html_sanitizer ) ybleachque lo teniamos pinneado sin poder subir la version.Despues django-braces lo usabamos solo para el LoginRequiredMixin que ahora viene con django.
Escribi unos cuantos tests, a ver que opinan!