Skip to content

Idea to show the dates on the albums #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
humitos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Idea to show the dates on the albums #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/pages/PreviousEditions/PreviousEditions.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
padding: var(--spacing-md) var(--spacing-md);
display: flex;
flex-direction: column;
align-items: center;
align-items: baseline;
Copy link
Member Author

@humitos humitos Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want everything to be aligned to the left, but only the bullets, not the title. I wasn't able to do that.

gap: var(--spacing-sm);
transition:
transform 0.2s,
Expand Down Expand Up @@ -154,12 +154,29 @@
margin-top: 4px;
}

.photo-date{
display: flex;
align-items: center;
justify-content: center;
gap: 6px;
color: var(--text-muted);
font-size: 14px;
line-height: 1.5;
margin-top: 4px;
}

.map-icon {
width: 18px;
height: 18px;
opacity: 0.6;
}

.calendar-icon {
width: 18px;
height: 18px;
opacity: 0.6;
}

Comment on lines 168 to +179
Copy link
Member Author

@humitos humitos Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to the specificity that I mentioned regarding the CSS classes.

Adding another icon here should automatically grab the CSS to avoid repeating the CSS rules for all the icons.

We should avoid the current pattern as much as possible.

Copy link
Member Author

@humitos humitos Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have rules like:

.photo-gallery img.icon {

}

or something similar with the same idea.

/* Projects Section */
.projects {
background: linear-gradient(
Expand Down
9 changes: 9 additions & 0 deletions src/pages/PreviousEditions/PreviousEditions.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import Footer from "../../components/Footer/Footer";
import cameraIcon from "../../assets/icons/camera.svg";
import externalLinkIcon from "../../assets/icons/external-link.svg";
import mapPinIcon from "../../assets/icons/map-pin.svg";
import calendarIcon from "../../assets/icons/calendar.svg";
import githubIcon from "../../assets/icons/project-github.svg";
import arrowBrown from "../../assets/icons/arrow-right-brown.svg";
import photo2025 from "../../assets/images/pycamp-cover-2025.webp";
Expand All @@ -18,24 +19,28 @@ function PreviousEditions() {
photos: photo2025,
link: "https://photos.app.goo.gl/Lw2M76V2bzYMZoFt6",
location: "Encinares de Escardiel - Castilblanco de los Arroyos, Sevilla",
date: "1 al 4 de mayo",
},
{
year: "2024",
photos: photo2024,
link: "https://photos.app.goo.gl/gPYLUEzDAokZ4PrQA",
location: "Casa de Colonias Aiguaviva - Guixers, Lleida",
date: "29 de marzo al 1 de abril",
},
{
year: "2023",
photos: photo2023,
link: "https://photos.app.goo.gl/zmtyihL3B3KaBtpF9",
location: "El Bosc de la Massana - Vilablareix, Girona",
date: "7 al 10 de abril",
},
{
year: "2022",
photos: photo2022,
link: "https://photos.app.goo.gl/GSeufqbsjHvXLJxZA",
location: "El Bosc de la Massana - Vilablareix, Girona",
date: "15 al 18 de abril",
},
];

Expand Down Expand Up @@ -110,6 +115,10 @@ function PreviousEditions() {
<img src={mapPinIcon} alt="" className="map-icon" />
<span>{edition.location}</span>
</div>
<div className="photo-date">
<img src={calendarIcon} alt="" className="calendar-icon" />
<span>{edition.date}</span>
</div>
</article>
))}
</div>
Expand Down