Emscripten: No extra rustc-cdylib-link-args on Rust >= 1.95#5874
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Mar 13, 2026
Merged
Emscripten: No extra rustc-cdylib-link-args on Rust >= 1.95#5874davidhewitt merged 2 commits intoPyO3:mainfrom
davidhewitt merged 2 commits intoPyO3:mainfrom
Conversation
hoodmane
force-pushed
the
emscripten-no-flags-rust-1.95
branch
3 times, most recently
from
301d797 to
468dfa4
Compare
davidhewitt
approved these changes
Mar 12, 2026
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks - I also bumped ci to build with 3.14 in #5455
hoodmane
force-pushed
the
emscripten-no-flags-rust-1.95
branch
from
468dfa4 to
9759ea7
Compare
We used to have to pass extra flags to build with Emscripten but 1. Emscripten 4.0.0 made WASM_BIGINT automatic 2. Rust version 1.95 learned how to build cdylibs rust-lang/rust#151704 We use Emscripten 3.1.58 to build for Python 3.12 which would be broken by dropping WASM_BIGINT but for Python 3.12 we also use JS eh which doesn't work at all with Rust version >= 1.93 so there's no added breakage. On the other hand, Python 3.13 uses Emscripten 4.0.9 and doesn't need `-sWASM_BIGINT`.
hoodmane
force-pushed
the
emscripten-no-flags-rust-1.95
branch
from
9759ea7 to
2d583f7
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
davidhewitt
approved these changes
Mar 13, 2026
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, I'll go ahead and apply what I think fixes the pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to have to pass extra flags to build with Emscripten but
set_output_kindfor Emscripten linker rust-lang/rust#151704We use Emscripten 3.1.58 to build for Python 3.12 which would be broken by dropping WASM_BIGINT but for Python 3.12 we also use JS eh which doesn't work at all with Rust version >= 1.93 so there's no added breakage.
On the other hand, Python 3.13 uses Emscripten 4.0.9 and doesn't need
-sWASM_BIGINT.