fix: Include semi-continuous in Variable.type property#635
Merged
FabianHofmann merged 1 commit intomasterfrom Mar 26, 2026
Merged
fix: Include semi-continuous in Variable.type property#635FabianHofmann merged 1 commit intomasterfrom
FabianHofmann merged 1 commit intomasterfrom
Conversation
Variable.type only checked integer and binary attributes, falling through to "Continuous Variable" for semi-continuous variables. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
FabianHofmann
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up on #593
Summary
Variable.typeonly checkedintegerandbinaryattributes, so semi-continuous variables incorrectly returned"Continuous Variable"semi_continuouschecktest_variable_typecovering all four variable typesNo Changelog entry needed if included in the release that adds semi continuous variables
Test plan
test_variable_typeverifies all four types: continuous, binary, integer, semi-continuous🤖 Generated with Claude Code