fix: Improve docstring wording of 'for regular members'#3120
fix: Improve docstring wording of 'for regular members'#3120Lee4test wants to merge 5 commits intoPycord-Development:masterfrom
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3120/head:pr-3120
git checkout pr-3120This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3120/head |
|
The start of a sentence should begin with a capital letter. The issue you are solving also references multiple other places that this need to be fixed. As far as I know you should not be commiting changes to the docs folder, as it will be auto-generated when the PR is merged. |
5286762 to
75cd298
Compare
|
Thank you for the review! I've fixed the capitalization issue and removed the changes in the generated docs folder. Please let me know if anything else needs to be adjusted. |
|
|
75cd298 to
d161e0e
Compare
|
Thanks for pointing that out. |
|
@Lee4test is there a reason you keep force-pushing instead of just making a new commit? |
|
I was amending to keep the commit history clean, but I'm happy to add follow-up commits instead if that's preferred. |
|
You don't have to do that in this repo, when the pull request is merged all commits will be squashed into one so you can make as many commits as you need |
|
Got it, thanks for the clarification! |
|
I am not sure if replacing "For regular members this" with just "This" makes it clearer. Specifically, saying "This is just their x" and then contradicting ourselves right after seems weird. But maybe I'm overthinking this. @JustaSqu1d maybe you have an idea ? |
Summary
This PR improves docstring wording by removing the phrase “For regular members.”
Closes #3117
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.