Skip to content

Remove outdated new pills#4772

Merged
frankharkins merged 1 commit intomainfrom
FH/new-pills
Mar 9, 2026
Merged

Remove outdated new pills#4772
frankharkins merged 1 commit intomainfrom
FH/new-pills

Conversation

@frankharkins
Copy link
Member

Removes new pills that were added > 3 weeks ago

@abbycross
Copy link
Collaborator

Thanks! I thought I recalled that there is a check that alerts us when the expiration date has passed - is that still true?

@Eric-Arellano
Copy link
Collaborator

I thought I recalled that there is a check that alerts us when the expiration date has passed - is that still true?

Yes, but someone has to look at the new GH issue: #4769.

@abbycross
Copy link
Collaborator

Ok, what I did not know is that it fails in an issue called "Extended checks failed"! I thought it would fail whenever we build a PR and prevent us from merging something new.

@Eric-Arellano
Copy link
Collaborator

I thought it would fail whenever we build a PR and prevent us from merging something new.

We could do that if you'd like! But we figured it would be really annoying because it would break unrelated PRs randomly. But we can do whatever process you'd like. If we made the change you suggest, we would definitely have less risk of not realizing that we need to remove new pills.

@abbycross
Copy link
Collaborator

I agree it would be much more annoying and probably the team would curse me for it! I'll discuss with them and see what they think. It might be enough just to know that we can't ignore the "extended checks failed" generated PRs 🤣

@frankharkins
Copy link
Member Author

We could maybe have the action make a PR removing the pills? Might not be too difficult

@frankharkins frankharkins added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit 60139fa Mar 9, 2026
6 checks passed
@frankharkins frankharkins deleted the FH/new-pills branch March 9, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Extended checks failed

3 participants