feat: implementation for group_degree_centrality, group_closeness_centrality, and group_betweenness_centrality#1565
Open
selmanozleyen wants to merge 7 commits intoQiskit:mainfrom
Open
Conversation
|
|
Collaborator
|
Some preliminary thoughts:
Using NetworkX as a ground source of truth is a great idea. But it's also nice not to be affected by their API changes. We had to do that for other centrality methods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi I added these three functions because I'd like to use them in squidpy instead of pure python version.
group_degree_centrality,group_closeness_centrality, andgroup_betweenness_centralityfor both digraph and graphNote
While writing cross-validation tests against NetworkX, I discovered that
NetworkX's
group_betweenness_centralityis buggy on directed graphs thatare not strongly connected (returns negative values, crashes with
KeyError).Filed upstream: networkx/networkx#8559.
The NX comparison tests here only use strongly-connected directed graphs to
avoid this.