[ak_aiyagari] Fix inconsistent household reference (hh → household)#706
Open
sudayuga wants to merge 2 commits intoQuantEcon:mainfrom
Open
[ak_aiyagari] Fix inconsistent household reference (hh → household)#706sudayuga wants to merge 2 commits intoQuantEcon:mainfrom
hh → household)#706sudayuga wants to merge 2 commits intoQuantEcon:mainfrom
Conversation
This PR resolves a naming inconsistency and potential bug across several functions where a global variable hh was referenced instead of the household argument passed into the function. This issue affects several key components of the model's implementation, including find_ss, popu_dist, compute_aggregates, and others.
Contributor
|
many thanks @sudayuga ! @HumphreyYang , could you please review? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several functions incorrectly referenced a global variable
hhinstead of using thehouseholdargument passed to them.This caused silent inconsistency and potential runtime failure if
hhis not defined in the global scope.Fix
hh.*references withhousehold.*backwards_opt,popu_dist,compute_aggregates,and
solve_backwardsto use the injectedhouseholdobject