Skip to content

Remove explicit call to InfiniteMPS in VUMPS and IDMRG #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AFeuerpfeil wants to merge 10 commits into
base: main
Choose a base branch
from
+11 −2
Open

Remove explicit call to InfiniteMPS in VUMPS and IDMRG #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
855787b
remove explicit call to InfiniteMPS in VUMPS and IDMRG
AFeuerpfeil Feb 28, 2026
f9858a4
fix formatting
AFeuerpfeil Feb 28, 2026
ce53a26
revert original change and instead use gaugefix! in the gauging step
AFeuerpfeil Mar 2, 2026
d2a2818
format
AFeuerpfeil Mar 2, 2026
76765e1
copy mps in VUMPSState to avoid modifying the input mps during the it…
AFeuerpfeil Mar 2, 2026
a86d1bc
copy instead of similar in IDMRG
AFeuerpfeil Mar 2, 2026
91fac79
fix vumps
AFeuerpfeil Mar 2, 2026
5a685d8
Merge branch 'pr-styles-vumps' of github.com:AFeuerpfeil/MPSKit.jl in…
AFeuerpfeil Mar 2, 2026
5a9525e
hopefully fix idmrg bug (no copy needed, as mps is copied at the begi…
AFeuerpfeil Mar 2, 2026
69ab162
hopefully fix idmrg
AFeuerpfeil Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/algorithms/groundstate/idmrg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,12 @@ function find_groundstate(mps, operator, alg::alg_type, envs = environments(mps,
end

alg_gauge = updatetol(alg.alg_gauge, it.state.iter, it.state.ϵ)
ψ′ = InfiniteMPS(it.state.mps.AR[1:end]; alg_gauge.tol, alg_gauge.maxiter)
V = _firstspace(it.state.mps.AR[1])
C₀ = isomorphism(storagetype(eltype(it.state.mps.AR)), V, V)
ψ′ = gaugefix!(
copy(it.state.mps), copy(it.state.mps.AR), C₀;
tol = alg_gauge.tol, maxiter = alg_gauge.maxiter
)
envs = recalculate!(it.state.envs, ψ′, it.state.operator, ψ′)
return ψ′, envs, it.state.ϵ
end
Expand Down
6 changes: 5 additions & 1 deletion src/algorithms/groundstate/vumps.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ function dominant_eigsolve(
)
log = IterLog("VUMPS")
iter = 0
mps = copy(mps)
ϵ = calc_galerkin(mps, operator, mps, envs)
alg_environments = updatetol(alg.alg_environments, iter, ϵ)
recalculate!(envs, mps, operator, mps; alg_environments.tol)
Expand Down Expand Up @@ -153,7 +154,10 @@ end

function gauge_step!(it::IterativeSolver{<:VUMPS}, state, ACs::AbstractVector)
alg_gauge = updatetol(it.alg_gauge, state.iter, state.ϵ)
return InfiniteMPS(ACs, state.mps.C[end]; alg_gauge.tol, alg_gauge.maxiter)
return gaugefix!(
state.mps, ACs, state.mps.C[end];
alg_gauge.tol, alg_gauge.maxiter
)
end
function gauge_step!(it::IterativeSolver{<:VUMPS}, state, ACs::AbstractMatrix)
alg_gauge = updatetol(it.alg_gauge, state.iter, state.ϵ)
Expand Down
Loading