Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report❌ Patch coverage is
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…or for real tensors in tests
leburgel
left a comment
There was a problem hiding this comment.
Overall looks good, I'm happy losing any restrictions on the contraction algorithm where possible. I don't know if contraction_metrics is the best name and whether this change will break things for many users, but I can't think of a better name and it shouldn't be too big of a change I guess.
Aside from the minor comments, can you update the changelog to record the fact that the truncation_error and condition_number have moved to a different place? We've been forgetting about that a bit, but I think this should definitely go in there at least.
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
|
Alright, the |
As suggested by @leburgel in #336, here we improve a couple of things about the
fixedpointoptimization routine:check_input(::typeof(fixedpoint), args...)method that verifies that the chosen inputs are compatible with the PEPS optimization algorithmleading_boundarycall should return aninfonamed tuple which contains acontraction_metricsfield that carries boundary-algorithm-specific information such as the truncation error, condition number, etc.PEPSOptimizeand also loosened type restrictions offixedpointsuch that it is compatible with different environment types.I'm not so sure yet about the name
contraction_metrics, so let me know what you think. After the first round of reviews I will update the examples such that they match the newfixedpoint.