Introduce wrapper structs for Trotter NN gates and MPOs#339
Draft
Yue-Zhengyuan wants to merge 10 commits intoQuantumKitHub:masterfrom
Draft
Introduce wrapper structs for Trotter NN gates and MPOs#339Yue-Zhengyuan wants to merge 10 commits intoQuantumKitHub:masterfrom
Yue-Zhengyuan wants to merge 10 commits intoQuantumKitHub:masterfrom
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two wrapper structs,
TrotterNNGatesandTrotterMPOs2ndNeighbor <: TrotterMPOsto store the Trotter evolution gates (so they are no longer stored as aLocalOperator) and the MPOs (so they are not just a plain array). They are designed to work withsu_iterinternally, and not intended to be accessed by users.I also make some improvements on how the gates and NNN MPOs are constructed from the Hamiltonian, so Hamiltonians with 1-site terms can also be used for simple update (previously I restricted them to only contain 2-site terms).
Suggestions on the design of
TrotterMPOsare welcome, as there are potentials to generalize time evolution to deal with 3-site terms, 3rd neighbor terms, or even more. But I prefer to write specific code for each case, as I don't think it's worthwhile to write a universal way to handle arbitrary Hamiltonians with Trotter decomposition.