Skip to content

also convert CUDA pointer#21

Merged
Jutho merged 1 commit intomainfrom
ld-gpuptr
Jan 20, 2026
Merged

also convert CUDA pointer#21
Jutho merged 1 commit intomainfrom
ld-gpuptr

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Jan 19, 2026

bump minimal Julia version

bump v0.4.3

TODO: this should get some tests (and I have to verify it actually resolves the TensorOperations issues with cuTENSOR)

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.85%. Comparing base (3fde672) to head (2458256).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ext/StridedViewsCUDAExt.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   93.64%   92.85%   -0.79%     
==========================================
  Files           5        5              
  Lines         236      238       +2     
==========================================
  Hits          221      221              
- Misses         15       17       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bump minimal Julia version

bump v0.4.3
@lkdvos
Copy link
Member Author

lkdvos commented Jan 20, 2026

Just ran the TensorOperations tests, I can confirm this fixes the issues. Do we want to already merge and tag this, since this is breaking for the downstream packages?

@kshyatt
Copy link
Member

kshyatt commented Jan 20, 2026

🚀 let's gooooooo

@lkdvos lkdvos requested a review from Jutho January 20, 2026 12:50
@Jutho
Copy link
Member

Jutho commented Jan 20, 2026

Thanks for fixing my alcohol mistakes.

@Jutho Jutho merged commit 8114e47 into main Jan 20, 2026
10 of 15 checks passed
@kshyatt
Copy link
Member

kshyatt commented Jan 20, 2026

Schneider Weisse has much to answer for

@lkdvos lkdvos deleted the ld-gpuptr branch January 20, 2026 13:36
@Jutho
Copy link
Member

Jutho commented Jan 22, 2026

Schneider Weisse has much to answer for

It might also have been listening to this music while coding:

https://youtu.be/IJGh50t6crw?si=-G4qnk4ohq6ifsFD&t=479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants