Merged
Conversation
fixes severe rendering bugs
took fake glass rendering out of the liquid_glass_package, put it into our own file so we can use it. format code
dewabisma
reviewed
Apr 9, 2026
| stickyAuth: true, | ||
| sensitiveTransaction: true, | ||
| ), | ||
| options: const AuthenticationOptions(biometricOnly: false, stickyAuth: true, sensitiveTransaction: true), |
Collaborator
There was a problem hiding this comment.
Funny we have this formatting change
Collaborator
Author
There was a problem hiding this comment.
IDK i just run melos run format, it did this
Collaborator
Author
There was a problem hiding this comment.
maybe it was wrong before
dewabisma
reviewed
Apr 9, 2026
dewabisma
requested changes
Apr 9, 2026
Collaborator
dewabisma
left a comment
dewabisma
left a comment
There was a problem hiding this comment.
Found one smell change, please see comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android liquid glass renderer is broken
This replaces it with a fake glass renderer based on the fake renderer inside of the liquid_glass_renderer package
Fix Android rendering artifacts in glass components
The
liquid_glass_rendererpackage uses GPU compositing layers (BackdropFilterLayer) that produce visual artifacts on Android -- tearing in glass buttons and icon buttons disappearing entirely during scroll.This PR adds
AndroidGlass, a pure-widget replacement that replicates the glass specular highlights using standardCustomPaint+ClipRRect, avoiding the problematic compositing layer.LiquidGlassBasenow routes toAndroidGlasson Android while keeping the fullLiquidGlasseffect on iOS.Changes:
liquid_glass_base.dart-- platform gate: iOS usesLiquidGlass, Android usesAndroidGlassandroid_glass.dart(new) -- self-contained glass widget with specular highlight painter, no dependency onliquid_glass_rendererMagic number explanation
0x1AFFFFFFisn't magic -- it's just your existingsurfaceGlasstheme color fromapp_colors.dart:It's white at 10% opacity. We use it as the fallback when callers pass
Colors.transparent(the default), since a fully transparent glass wouldn't be visible without the backdrop blur that the realLiquidGlassprovides.