fix: serialize prettier formatting to prevent flaky tests#106
Open
fix: serialize prettier formatting to prevent flaky tests#106
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Query Doctor Analysis
82 queries analyzed
2 pre-existing issues
SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
indexassets(event_id, uploader_id, inserted_at desc)
cost 15,918 → 1,631 (90% reduction)SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
indexguest_ip_addresses(ip_address)
cost 126 → 9 (93% reduction)
Using assumed statistics (10000 rows/table). For better results, sync production stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prettier-plugin-sqlis not safe to call concurrently.QueryCache.sync()runs up to 10RecentQuery.analyze()calls in parallel, each callingprettier.format(). Under CI load, some calls throw silently (caught by the existing try/catch), causing queries to retain their original lowercase casing instead of being uppercased — leading to non-deterministic test failures.Sema(1)) aroundformatQueryto serialize prettier calls, making output deterministic.Test plan
remote.test.ts(8 tests) andquery-optimizer.test.ts(5 tests) — both previously failing in thereleaseCI job🤖 Generated with Claude Code