fix: race condition causing GZIP corruption on restart#548
Open
yetval wants to merge 1 commit intoQuiteAFancyEmerald:masterfrom
Open
fix: race condition causing GZIP corruption on restart#548yetval wants to merge 1 commit intoQuiteAFancyEmerald:masterfrom
yetval wants to merge 1 commit intoQuiteAFancyEmerald:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481
As requested, here's the fix for the restart race condition. Found some more bugs on the way:
views/dist-newand atomically renames toviews/diston completion, eliminating the window where the server could serve plain HTML with a gzip Content-Encodingnpm run killnow usesnpx pm2 kill; pkill -f "node backend.js" || trueinstead ofpkill node, which was killing the pm2 daemon and leaving nginx with stale connectionspaintSourceon vendor scram bundles to fix intermittent esbuild failures on repeated builds