Open
Conversation
|
If I understand correctly, this fix avoids an infinite loop of recursive calls to |
erikschuitema
suggested changes
May 19, 2025
erikschuitema
left a comment
erikschuitema
left a comment
There was a problem hiding this comment.
To me it looks like the goal of the PR can be achieved with less code, in a clearer way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under certain conditions, a websocket handler will get stuck in a loop erroring out while attempting to write to a closed websocket. Over time this can lead to resource leakage and eventually leading to an unresponsive rosbridge server.
This PR contains a fix (not sure if the best/right way to achieve it) for this loop code path and thus allowing the resources to be cleaned up properly.