[Gluon] [Triton] [MI450] [MI350] Enable Triton/Gluon MLA with block_size 64 preshuffled kv_buffer option for decode#578
Open
[Gluon] [Triton] [MI450] [MI350] Enable Triton/Gluon MLA with block_size 64 preshuffled kv_buffer option for decode#578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enable MLA option for decode (Triton for MI350 and Gluon for MI450)
On MI350, the implementation here is just to verify the results on MI350. The primary purpose of this PR is to enable Gluon MLA for decode on MI450.
ATOM_ENABLE_TRITON_MLA_DECODEfor the user to toggle between Triton/Gluon MLA verses ASM MLAatom/model_ops/attentions/aiter_mla.py, to fix the block_size 64.slot_mappingwithblock_tables.concat_and_cache_mla(Triton) andfused_qk_rope_concat_and_cache_mla(Triton) that supports KV buffer pre-shufflingThis PR depends on ROCm/aiter#2492
Server commend:
lm_eval results: