Closed
Conversation
Contributor
Author
|
This depends on #1252 and makes only sense once that has landed. |
dpalermo
requested changes
May 16, 2025
dpalermo
requested changes
May 22, 2025
dpalermo
approved these changes
Jun 2, 2025
Contributor
Author
|
I think we want to wait for #1463 to land and then use this wrapper instead of plain |
Contributor
|
As it is, the aomp-shellcheck script automatically modifies the files given as arguments in some circumstances (i.e. if they have failing checks in the "patchable" check list), which is probably not desirable for the GitHub workflow case. |
Contributor
Author
|
Good point. Should there be a |
Contributor
|
I think so, something like that. |
Contributor
|
I've added a new --check-only option in the version up on #1463 now. |
e-kwsm
suggested changes
Jun 4, 2025
Use new values of no-loop and big-jump-loop mode constants
When disabling OMPT support this test will crash with a segementation fault. With this fix the test will still fail but no longer seg fault.
…nge the logs to use the build directory
Reason: Avoid test-pipeline disturbance due to OpenMP move of omptest
Fix omptest-based + CMake tests - export of omptest_DIR fixes find_package(omptest) Enhance build steps (header inclusion and linking) due to omptest improvements. Test names: * omptest-device-emi * omptest-device-non-emi * veccopy-ompt-target-cmake
- Avoids register allocation issue at runtime
- Which is incorrectly reported by HSA as:
HSA_STATUS_ERROR_INVALID_ISA: The instruction set architecture is invalid.
Co-authored-by: Abid Qadeer <haqadeer@amd.com>
There was an issue seen with alma8 where rocprofiler-sdk was picking up the newest python version in /usr/local/bin, which is causing cmake errors. Determine the current python3 default version and pass it through.
Deprecated docs for SLES, Ubuntu, and RHEL/CentOS installs. We now build on AlmaLinux and distrubute a tar file that can be used on many operating systems.
Add -k 0 argument to installation - CK installation may fail intermediately, hiding other "build" errors Add print of CK-INSTALL-SUCCESS
jplehr
requested review from
carlobertolli,
saiislam and
zGoldthorpe
as code owners
Contributor
Author
|
Apologies for the rebase f-up. |
Contributor
Author
|
Opened #1989 as clean version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.