Added missing set_device calls for nvidia_transform#52
Open
Serge45 wants to merge 1 commit intoROCm:rocm_enabled_multi_backendfrom
Open
Added missing set_device calls for nvidia_transform#52Serge45 wants to merge 1 commit intoROCm:rocm_enabled_multi_backendfrom
Serge45 wants to merge 1 commit intoROCm:rocm_enabled_multi_backendfrom
Conversation
lcskrishna
approved these changes
Jan 3, 2025
|
They are present in nvidia_transform - https://github.com/Serge45/bitsandbytes/blob/feature/miss-set-device-transform/bitsandbytes/functional.py#L516-L520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
HIP_ENVIRONMENT is Truecase, there's missing calls ofpre_callandpost_callfor proper device setting fornvidia_transform.