Remove OpenMP::omp imported target from rocwmma#419
Merged
estewart08 merged 1 commit intoamd-stagingfrom Mar 11, 2026
Merged
Conversation
Collaborator
|
@adeljo-amd can you review and sync #411 if necessary? Thanks |
Contributor
Oops sorry, my email notifications was a mess and I didn't see this before merging in 411. This LGTM, though I agree about the removal of the target being hacky |
Collaborator
|
@estewart08 can you also include the newly added |
Recently rocwmma switched to using the openmp-config in ROCm, which provides the OpenMP::omp target. I see that the OpenMP::OpenMP_CXX target was removed before so we are just adding to that logic. That being said I think removing these targets is hacky and rocwmma should instead use add_dependency in their config to resolve/lookup these targets.
estewart08
force-pushed
the
amd/dev/estewart/remove-omp-target-rocwmma
branch
from
7d1f4a3 to
63c6b83
Compare
Contributor
Author
Done. |
Contributor
Author
|
@zichguan-amd Can you comment on the failing checks? From what I can tell they are unrelated to the patch. |
Collaborator
|
@estewart08 the rocprofiler-sdk failures are unrelated, you can go ahead and merge this. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently rocwmma switched to using the openmp-config in ROCm, which provides the OpenMP::omp target. I see that the OpenMP::OpenMP_CXX target was removed before so we are just adding to that logic. That being said I think removing these targets is hacky and rocwmma should instead use add_dependency in their config to resolve/lookup these targets.