[TensileLite] Fix YAML parameter type mismatches — hipsparselt#5684
Merged
[TensileLite] Fix YAML parameter type mismatches — hipsparselt#5684
Conversation
Contributor
Author
Fix bool/int/float type mismatches in library logic YAML files for: aquavanjaram (gfx942), gfx950 YAML `false`/`true` where `int 0`/`1` is expected (and vice versa) produce different msgpack wire types, causing `std::bad_cast` at C++ deserialization time. Generated by `utilities/fix_yaml_types.py` from hipblaslt. Zero mismatches remain. Refs: AIGECORE-189 Depends on: #5001 (fix wrong-type literals in assignDerivedParameters) #5002 (add build-time type validation for library logic YAMLs) --- Merge conflict resolution --- If you are resolving a merge conflict between this commit and a tuning update to these YAML files: your tuning changes take precedence. For each conflicted file, accept your version of the file. After resolving all conflicts and staging the files, run: python3 <path-to-hipblaslt>/utilities/fix_yaml_types.py <arch_directory> to re-apply the type fixes on top of your tuning data. Verify it reports zero mismatches, then complete the merge/rebase. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
talumbau
force-pushed
the
users/talumbau/fix-yaml-types-hipsparselt
branch
from
4e55ef0 to
eb693e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
YAML
false/truewhereint 0/1is expected (and vice versa) producedifferent msgpack wire types, causing
std::bad_castat C++ deserializationtime on any multi-architecture build where a wrong-type .dat file is loaded.
This fixes the existing mismatches in hipsparselt.
Refs: AIGECORE-189
Depends on: #5001, #5002
Technical Details
Mechanical fix generated by
utilities/fix_yaml_types.py(from hipblaslt) for:aquavanjaram (gfx942), gfx950
187 files changed. Zero mismatches remain after fix.
See #5002 for full background on the bug, the affected parameters, and the
detection/fix tooling.
Test Plan
python3 <path-to-hipblaslt>/utilities/fix_yaml_types.py <arch_dir>on each architecture directory — verify it reports 0 mismatches (idempotent check)
type-mismatch warnings at build time
Test Result
fix_yaml_types.pyreports zero remaining mismatches across all 187 files.Merge Conflict Resolution
If you are resolving a merge conflict between this commit and a tuning
update to these YAML files: your tuning changes take precedence. For each
conflicted file, accept your version of the file. After resolving all
conflicts and staging the files, run:
to re-apply the type fixes on top of your tuning data. Verify it reports
zero mismatches, then complete the merge/rebase.
Submission Checklist