[MIOpen] Fixed warnings about unused parameters#5690
Closed
[MIOpen] Fixed warnings about unused parameters#5690
Conversation
stulebae
changed the title
vasily-vm
reviewed
Mar 23, 2026
vasily-vm
reviewed
Mar 25, 2026
vasily-vm
reviewed
Mar 25, 2026
vasily-vm
reviewed
Mar 25, 2026
vasily-vm
reviewed
Mar 25, 2026
vasily-vm
requested changes
Mar 25, 2026
Contributor
vasily-vm
left a comment
vasily-vm
left a comment
There was a problem hiding this comment.
restore interface plz
even if it's design issue, warning removal PR isn't a right place to fix it
stulebae
requested review from
randyspauldingamd
and removed request for
randyspauldingamd
randyspauldingamd
requested changes
Apr 9, 2026
Contributor
randyspauldingamd
left a comment
randyspauldingamd
left a comment
There was a problem hiding this comment.
Please remove all changes, cleanups etc. that are not directly related to unused. After that I'll come back and review the unused fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Attempt of reducing number warnings in build stage.
Technical Details
from file cmake/EnableCompilerWarnings.cmake option -Wno-unused-parameter was removed.
Part of effort to fix #4646