[hipDNN] Fix flaky IntegrationPluginLoading.PluginWithIncompatibleApiVersion test#5693
Merged
SamuelReeder merged 1 commit intodevelopfrom Mar 23, 2026
Conversation
test_incompatible_version_plugin was missing from the add_dependencies() list, causing flaky test failures when ninja's parallel build order didn't build the plugin .so before running the test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.21%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5693 +/- ##
========================================
Coverage 66.81% 66.81%
========================================
Files 1849 1849
Lines 285013 285013
Branches 40026 40026
========================================
+ Hits 190428 190429 +1
Misses 78190 78190
+ Partials 16395 16394 -1
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
CMiservaAMD
approved these changes
Mar 22, 2026
SamuelReeder
deleted the
users/sareeder/fix-incompatible-version-plugin-dep
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_incompatible_version_pluginwas missing from theadd_dependencies()list forpublic_hipdnn_backend_testsintests/backend/CMakeLists.txt.sowas never declared a build dependency. This meant the plugin likely only existed if you built everything, andninja checkwouldn't necessarily build it since it isn't dependent.Test plan
IntegrationPluginLoading.PluginWithIncompatibleApiVersionwithpublic_hipdnn_backend_testsand confirm it passes consistentlyninja checkto confirm no regressions