Conversation
Contributor
Author
|
Failing CI expected; did not add parallel to the appraised gemfiles. If someone is willing to share their benchmarks using this branch in the comments. ❤️ Am wondering if this PR can make a difference or if this approach is not right (am not too familiar with the internals of the the parallel gem—and in general this matter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build process is bottlenecked by sequential page rendering. Each page is currently rendered linear (one-by-one).
Using the
parallelgem, you can allow multiple pages to be rendered concurrently. 🍾The number of threads is auto-detected based on CPU cores via the parallel gem (can be configured via
Perron.config.build_threads: name TBD).Some stats 📈
Benchmark (Rails Designer site, 483 pages):
If you have a medum plus-sized site (500+ pages), do add
config.parallel_rendering = trueto the Peron initializer to enable parallel rendering (it is off/false by default)Some notes: