Fix FreshRSS Reader API item discovery window based on published-date ot#5156
Open
mncaudill wants to merge 1 commit intoRanchero-Software:mainfrom
Open
Fix FreshRSS Reader API item discovery window based on published-date ot#5156mncaudill wants to merge 1 commit intoRanchero-Software:mainfrom
mncaudill wants to merge 1 commit intoRanchero-Software:mainfrom
Conversation
Reader API sync for the FreshRSS/Miniflux path used lastArticleFetchStartTime to compute the `ot` parameter for `/stream/items/ids`. On these servers, `ot` is applied to entry published date (not read/unread state-change time). This can drop entries from discovery when: 1. an entry is published before desktop’s last fetch timestamp, 2. the entry is read on phone before desktop ingests it, 3. desktop sync then queries with `ot=lastArticleFetchStartTime`. Result: the item may never be fetched locally and can appear to “disappear” until manually toggled unread server-side. Repro: - FreshRSS/Miniflux Reader API account. - Read an unread article on phone first. - Open/sync desktop NetNewsWire. - Article is missing unless marked unread again on the server. Fix: - For ReaderAPI variant `.freshRSS`, stop using lastArticleFetchStartTime for account-level item ID discovery. - Use a stable rolling baseline window (now - 3 months) for `ot` instead. - Keep existing last-fetch behavior for non-FreshRSS Reader API variants. Tests: - Add ReaderAPICaller tests asserting: - FreshRSS uses baseline window for `ot`. - Generic Reader API continues using lastArticleFetchStartTime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader API sync for the FreshRSS/Miniflux path used lastArticleFetchStartTime to compute the
otparameter for/stream/items/ids.On these feed readers,
otis applied to entry published date (not read/unread state-change time). This can drop entries from discovery when:ot=lastArticleFetchStartTime.Result: the item may never be fetched locally and can appear to “disappear” until manually toggled unread server-side.
Repro:
Fix:
.freshRSS, stop using lastArticleFetchStartTime for account-level item ID discovery.otinstead.Tests:
ot.