Avoid a narrowing warning via explicit cast#1398
Merged
eddelbuettel merged 2 commits intomasterfrom Sep 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a narrowing warning that occurs when compiling with clang++ using strict warning flags. The issue arises because std::string_view::size() returns a size_t (which can be long int) but the R function Rf_mkCharLen() expects an int parameter.
- Added explicit cast from
size_ttointto prevent narrowing warning - Updated ChangeLog to document the fix
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| inst/include/Rcpp/internal/wrap.h | Added explicit cast to suppress narrowing warning in make_charsexp__impl__cstring function |
| ChangeLog | Documented the narrowing warning fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brian Ripley runs his M1mac checks under
clnag++with options-Wall -pedantic -Wconversion -Wno-sign-conversionand this throws up some narrowing warnings. This minimal PR suppresses one where C++size()returnslong intand R wants anint.Checklist
R CMD checkstill passes all tests