Skip to content

fix Rtools gcc on old fwrite #7690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tdhock wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −2
Draft

fix Rtools gcc on old fwrite #7690

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e74ebaf
replace types with const void *
Mar 31, 2026
8605c4b
atime: require C99 compatibility
aitap Apr 5, 2026
21bda69
Merge branch 'master' into fix-rtools-types
aitap Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,13 @@ test.list <- atime::atime_test_list(
file.path("src", "init.c"),
paste0("R_init_", Package_regex),
paste0("R_init_", gsub("[.]", "_", new.Package_)))
# require C<23 for empty prototype declarations to work, #7689
descfile = file.path(new.pkg.path, "DESCRIPTION")
desc = as.data.frame(read.dcf(descfile))
desc$SystemRequirements = paste(
c(desc$SystemRequirements, "USE_C99"),
collapse = "; ")
write.dcf(desc, descfile)
# allow compilation on new R versions where 'Calloc' is not defined
pkg_find_replace(
file.path("src", "*.c"),
Expand Down Expand Up @@ -199,11 +206,11 @@ test.list <- atime::atime_test_list(
v2 = sample(5L, N, TRUE)
)
},
expr = data.table:::`[.data.table`(d, , max(v1) - min(v2), by = id),
PR7401="0216983c51e03e3f61d5e6f08f4ba0c42cceb22c", # Merge commit (https://github.com/Rdatatable/data.table/commit/0216983c51e03e3f61d5e6f08f4ba0c42cceb22c) of a PR (https://github.com/Rdatatable/data.table/pull/7401) which increased speed and memory usage of this test (https://github.com/Rdatatable/data.table/issues/7687)
Before = "7a9eaf62ede487625200981018d8692be8c6f134", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/515de90a6068911a148e54343a3503043b8bb87c) in the PR (https://github.com/Rdatatable/data.table/pull/4164/commits) that introduced the regression
Regression = "c152ced0e5799acee1589910c69c1a2c6586b95d", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/15f0598b9828d3af2eb8ddc9b38e0356f42afe4f) in the PR (https://github.com/Rdatatable/data.table/pull/4558/commits) that fixes the regression
Fixed = "f750448a2efcd258b3aba57136ee6a95ce56b302"), # Second commit of the PR (https://github.com/Rdatatable/data.table/pull/4558/commits) that fixes the regression
Fixed = "f750448a2efcd258b3aba57136ee6a95ce56b302", # Second commit of the PR (https://github.com/Rdatatable/data.table/pull/4558/commits) that fixes the regression
expr = data.table:::`[.data.table`(d, , max(v1) - min(v2), by = id)),

# Issue with sorting again when already sorted, as reported in https://github.com/Rdatatable/data.table/issues/4498
# Test case adapted from https://github.com/Rdatatable/data.table/pull/4501#issue-625311918 which is the fix PR.
Expand Down
Loading