Add wildcard container selection and some code cleanup#47
Open
d-EScape wants to merge 1 commit intoRed5d:masterfrom
Open
Add wildcard container selection and some code cleanup#47d-EScape wants to merge 1 commit intoRed5d:masterfrom
d-EScape wants to merge 1 commit intoRed5d:masterfrom
Conversation
For lack of a better name I called the option --wildcard (-w). Ik will select al containers that have the specified text in their names. Use case: easily create stack files to import in portainer. Example: I have renamed my domotica related containers to dom.domoticz, dom.mqtt, dom.zwave etc. I can create 1 stack file by doing a 'autocompose.py -w dom.'
Owner
|
@d-EScape The wildcard addition is appreciated, though could you please review the conflicts here? I looked through to try and fix them myself, but not sure exactly how some of your "code cleanup" items will work with the most recent updates. |
Contributor
Author
|
Thanks @demon! The regex approach in #57 looks much more elegant. Is there any reason for exporting unused networks in that case? If so, can you change this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For lack of a better name I called the option --wildcard (-w). It will select all containers that have the specified text in their names.
Use case: easily create stack files to import in portainer.
Example: I have renamed my domotica related containers to dom.domoticz, dom.mqtt, dom.zwave etc. I can create 1 stack file by doing a
'autocompose.py -w dom.'
output has been checked with docker-compose config