[TESTS] Add global random seed for deterministic test#525
Merged
ogajduse merged 4 commits intoRedHatQE:masterfrom Apr 22, 2026
Merged
[TESTS] Add global random seed for deterministic test#525ogajduse merged 4 commits intoRedHatQE:masterfrom
ogajduse merged 4 commits intoRedHatQE:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make tests/test_hawkular.py deterministic by fixing the randomness source so that sampling-based test setup is reproducible across runs.
Changes:
- Imports
seedfrom Python’srandommodule. - Seeds the global RNG (
seed(17)) at module import time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thank you for your contribution, @Stephen0512! |
ogajduse
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR sets a fixed global random seed after imports in the test file to ensure deterministic and reproducible test behavior.
Motivation
Some tests rely on randomness without a fixed seed, which can lead to flaky tests, inconsistent CI results, and difficulty reproducing failures.
Change
A global random seed is initialized to make random behavior consistent across test runs.
Benefits
The issue was identified during an ongoing research project.