[RAI-46856] Add per-thread lock waiting time#275
Open
kpamnany wants to merge 3 commits intov1.10.2+RAIfrom
Open
[RAI-46856] Add per-thread lock waiting time#275kpamnany wants to merge 3 commits intov1.10.2+RAIfrom
kpamnany wants to merge 3 commits intov1.10.2+RAIfrom
Conversation
kpamnany
force-pushed
the
kp-codegen-lock-wt-metric
branch
from
d619142 to
8b0eca3
Compare
nickrobinson251
approved these changes
Feb 19, 2026
base/timing.jl
Outdated
| diff.malloc + diff.realloc + diff.poolalloc + diff.bigalloc | ||
| end | ||
|
|
||
| lock_waiting_time(tid::Int16) = ccall(:jl_get_thread_lock_waiting_time, UInt64, (Int16,), tid) |
Member
There was a problem hiding this comment.
Suggested change
| lock_waiting_time(tid::Int16) = ccall(:jl_get_thread_lock_waiting_time, UInt64, (Int16,), tid) | |
| lock_waiting_time_ns(tid::Integer) = ccall(:jl_get_thread_lock_waiting_time, UInt64, (Int16,), convert(Int64, tid)) |
Member
There was a problem hiding this comment.
just for convenience, so we can write lock_waiting_time_ns(1) rather than having to write lock_waiting_time_ns(Int16(1))
Alongside per-task lock waiting time. Also add an accessor for a thread's lock waiting time and also for a combined, all-threads lock waiting time.
kpamnany
force-pushed
the
kp-codegen-lock-wt-metric
branch
from
ecf1d65 to
60280a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Alongside per-task lock waiting time. Also add an accessor for a thread's lock waiting time and also for a combined, all-threads lock waiting time.
Checklist
Requirements for merging:
port-to-*labels that don't apply.