Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR overhauls the CLI interface for the LQP parser to provide clearer argument semantics and better default behavior. The main changes are replacing separate --bin/--json flags with a unified --format argument and adding default output paths so users can simply run lqp foo.lqp without additional arguments.
- Replaces
--bin,--json, and--outflags with--formatand-o/--outfor clearer argument handling - Adds default behavior where
foo.lqpoutputs tofoo.bin(orfoo.jsonwith--format json) - Consolidates file and directory processing logic to use the new argument structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python-tools/src/lqp/parser.py | Refactored CLI argument parsing and processing functions to use new format/output structure |
| python-tools/README.md | Updated documentation to reflect new CLI usage patterns and examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
davidwzhao
reviewed
Oct 7, 2025
| else: | ||
| raise ValueError(f"Unsupported format: {format_type}") | ||
|
|
||
| def process_directory(lqp_directory, format_type, output_base, output_to_stdout, validate=True): |
Contributor
There was a problem hiding this comment.
Maybe i missed something, is output_base used? Maybe we should also support something like lqp -o output/folder input/folder?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overhauls the CLI so that
foo.lqpfile tofoo.binand similarly so for directories. So now you can just do--bin,--json, and--outinteract with each other. Now we make this explicit by having a--formatargument where BIN and JSON emitting is explicitly specified.--outhas not changed in behavior.