Add an option for exporting CSV files as a table#178
Closed
davidwzhao wants to merge 5 commits intomainfrom
Closed
Add an option for exporting CSV files as a table#178davidwzhao wants to merge 5 commits intomainfrom
davidwzhao wants to merge 5 commits intomainfrom
Conversation
comnik
reviewed
Feb 16, 2026
Comment on lines
+70
to
+104
| message ExportCSVConfig { | ||
| string path = 1; | ||
| repeated ExportCSVColumn data_columns = 2; | ||
|
|
||
| optional int64 partition_size = 3; | ||
| optional string compression = 4; | ||
| optional bool syntax_header_row = 5; | ||
| optional string syntax_missing_string = 6; | ||
| optional string syntax_delim = 7; | ||
| optional string syntax_quotechar = 8; | ||
| optional string syntax_escapechar = 9; | ||
|
|
||
| // TODO: support data integration options, e.g., private tokens for private buckets etc. | ||
| } | ||
|
|
||
| message ExportCSVColumn { | ||
| string column_name = 1; | ||
| RelationId column_data = 2; | ||
| } | ||
|
|
||
| message ExportCSVTableConfig { | ||
| string path = 1; | ||
| RelationId table_def = 2; | ||
|
|
||
| optional int64 partition_size = 3; | ||
| optional string compression = 4; | ||
| optional bool syntax_header_row = 5; | ||
| optional string syntax_missing_string = 6; | ||
| optional string syntax_delim = 7; | ||
| optional string syntax_quotechar = 8; | ||
| optional string syntax_escapechar = 9; | ||
|
|
||
| // TODO: support data integration options, e.g., private tokens for private buckets etc. | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
For loading I went with the "locator" abstraction, because there is so much shared CSV configuration, that doesn't depend on where exactly the CSV is ultimately coming from.
I feel like something similar would be appropriate here. Keep the generic ExportCSVConfig but generalize repeated ExportCSVColumn to something like a ExportCSVSource, which abstracts over "bunch of GNF columns" and "single wide table definition".
There is some backwards compatibility annoyance here, but I think overall it would be cleaner.
Contributor
Author
|
Closing in favour of #199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.