Introduce DateFormatter and NumberFormatter #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
============================================
+ Coverage 99.27% 99.31% +0.04%
- Complexity 132 141 +9
============================================
Files 12 14 +2
Lines 276 294 +18
============================================
+ Hits 274 292 +18
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds two new built-in formatters for common number and date formatting needs, with documentation and unit tests.
Changes:
- Introduces
NumberFormatter(wrapsnumber_format) andDateFormatter(wrapsDateTime+date_format) implementingFormatter - Adds unit tests covering typical formatting and “return input unchanged” behavior
- Adds formatter documentation pages and links them from the README
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/NumberFormatter.php | Implements numeric string formatting via number_format() with configurable separators/decimals |
| src/DateFormatter.php | Implements date parsing/formatting via DateTime + date_format() |
| tests/Unit/NumberFormatterTest.php | Adds coverage for numeric formatting and non-numeric passthrough |
| tests/Unit/DateFormatterTest.php | Adds coverage for date formatting and unparsable-input passthrough |
| docs/NumberFormatter.md | Documents NumberFormatter usage and behavior |
| docs/DateFormatter.md | Documents DateFormatter usage and behavior |
| README.md | Adds the new formatters to the documentation table and updates contributor metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alganet
force-pushed
the
number-date
branch
3 times, most recently
from
d688379 to
abc04a6
Compare
Introduce formatters for the typical use cases of formatting numbers and dates. Internally, those formatters use `number_format` and `date_format` respectively. If a date cannot be parsed in runtime, the formatter will return the input unmodified. Similarly, if some input is not numeric, the numeric formatter will return it unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce formatters for the typical use cases of formatting numbers and dates.
Internally, those formatters use
number_formatanddate_formatrespectively.If a date cannot be parsed in runtime, the formatter will return the input unmodified. Similarly, if some input is not numeric, the numeric formatter will return it unchanged.