Open
Conversation
…ng publishing of move
Daniel-Martin576
suggested changes
Mar 26, 2021
Contributor
Daniel-Martin576
left a comment
Daniel-Martin576
left a comment
There was a problem hiding this comment.
Looks good. Just some nitpicks 👍
| int ddepth = CV_8UC1; | ||
| cv::Laplacian(frame, edges, ddepth); // use edge to get better Hough results | ||
| convertScaleAbs(edges, edges); | ||
| edges = frame; |
Contributor
There was a problem hiding this comment.
Does this override edges?
| convertScaleAbs(edges, edges); | ||
| edges = frame; | ||
| cv::dilate(edges, edges, kernel(4, 4)); // clearer debug image and slightly better detection | ||
| cv::cvtColor(edges, output, cv::COLOR_GRAY2BGR); // for debugging |
Contributor
There was a problem hiding this comment.
Call output variable debug.
| // calc angle and decide if it is a stop bar | ||
| double distanceX = p2.x - p1.x; | ||
| double distanceY = p2.y - p1.y; | ||
| double currAngle = atan(fabs(distanceY / distanceX)) * 180 / CV_PI; // in degrees |
Contributor
There was a problem hiding this comment.
Does this break if distanceX = 0?
Comment on lines
+124
to
+125
| findStopBarFromHough(frame, debug, stopBarAngle, stopBarGoalAngle, stopBarGoalAngleRange, | ||
| stopBarTriggerDistance, houghThreshold, houghMinLineLength, houghMaxLineGap); |
Contributor
There was a problem hiding this comment.
Why are some of these variables passed if they are global?
Comment on lines
+69
to
+70
| double rho = 1; // distance resolution | ||
| double theta = CV_PI / 180; // angular resolution (in radians) pi/180 is one degree res |
Contributor
There was a problem hiding this comment.
Kinda magic numbers... Maybe const global variables? Doesn't matter that much
|
|
||
| cv::Point midpoint = (p1 + p2) * 0.5; | ||
|
|
||
| if (fabs(stopBarGoalAngle - currAngle) <= stopBarGoalAngleRange) { // allows some amount of angle error |
Contributor
There was a problem hiding this comment.
shortest_angular_distance() for fabs(stopBarGoalAngle - currAngle)?
Comment on lines
+161
to
+167
| nhp.param("stopbar_near", stopbar_near_topic, std::string("/stopbar_near")); | ||
| nhp.param("stopbar_angle", stopbar_angle_topic, std::string("/stopbar_angle")); | ||
| nhp.param("sleep_adjust", sleepConstant, 1.0); | ||
|
|
||
| nhp.param("overhead_image_subscription", overhead_image_sub, std::string("/lines/detection_img_transformed")); | ||
|
|
||
| nhp.param("speed_subscription", speed_topic, std::string("/speed")); |
Contributor
There was a problem hiding this comment.
If you are going to do slash + topic name (/blah), you can just do nh.param, but you don't have to change it
| <param name="stopbar_angle" type="string" value="/stopbar_angle"/> | ||
|
|
||
| <!-- Camera Params--> | ||
| <param name="overhead_image_subscription" type="string" value="/camera_center/lines/detection_img_transformed" /> |
Contributor
There was a problem hiding this comment.
How did you even test this? Aka what launch file did you run to get this topic?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #368