Support git submodules; Add "always" option; Fix compatibility with ESPHome 2024.3.1 and later; Update example#1
Closed
ypid wants to merge 4 commits intoRoboMagus:mainfrom
Closed
Conversation
read_config_file has been removed on 2024-03-26 from ESPHome source code with f00d8760807b9def3e837ccfa32d49faf73f9943. It is an unused import thus it is just removed.
Owner
|
Thanks for your interest in this component! I like the changes you're suggesting, but here are a couple of suggestions:
|
Author
I opened #2 as draft PR for now.
Old/bad habits I guess, sorry. Done that so lets close this MR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS: Awesome component, exactly what I was looking for! Not a lot of people seem to care about features like that which improve tracing/auditing/debugging. But yeah, maybe that is also the enterprise smart home syndrome? I work in IT also of course ;-)
PPS: You might also be interested in Reproducible Builds. My goal is to use Nix to build my firmware fully reproducible.
esphomeis packaged in Nixpkgs so that is a start.