fix: app crashing because of ModalSectionSelects#6952
fix: app crashing because of ModalSectionSelects#6952divyanshu-patil wants to merge 4 commits intoRocketChat:developfrom
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe Section component was refactored to remove Text import and theme-based color styling. Fields component now renders each field within View wrappers instead of Text components, and no longer accepts a theme parameter. This resolves the crash when rendering ModalSectionSelects with section blocks. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes
<Text>wrapper with<View>- allows complex components like<Markdown>to render{ color: themes[theme].fontDefault }inline style (no longer needed without<Text>)Issue(s)
closes #6951
How to test or reproduce
Screenshots
app.crash.fix.mp4
Types of changes
Checklist
Further comments