fix(data): preserve HTML entities in file writes, diffs, and commands #11390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10804
Summary
unescapeHtmlEntities()calls fromWriteToFileTool,ApplyDiffTool, andExecuteCommandToolthat converted HTML entities (<,>,&,',") to literal characters during file writes, diff application, and command execution'becoming'breaks JSX attributes,<becoming<breaks HTML entity display)>was silently converted to>before executioncanonicalCommandalias per review feedbackBackground
HTML entity decoding was originally added in PR #2120 (Mar 2025) as a workaround for XML-encoded tool-call payloads. When models used the XML tool protocol, special characters in tool parameters were XML-encoded (
&became&,<became<, etc.), so the tool layer decoded them before execution. Over time the same decoding was applied to file writes and diff application, where it caused data corruption by mutating HTML/JSX/TSX content. The XML tool protocol has since been removed entirely — the codebase now uses native JSON tool calls exclusively, which do not XML-encode parameters. TheunescapeHtmlEntities()calls are no longer needed.Test plan
text-normalizationmock from integration tests (executeCommandTimeout.integration.spec.ts)