Skip to content

fix(providers): do not force openai-strict tools for zai/ollama #11406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xMink wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Open

fix(providers): do not force openai-strict tools for zai/ollama #11406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/api/providers/native-ollama.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ export class NativeOllamaHandler extends BaseProvider implements SingleCompletio

const aiSdkMessages = convertToAiSdkMessages(messages)

const openAiTools = this.convertToolsForOpenAI(metadata?.tools)
const aiSdkTools = convertToolsForAiSdk(openAiTools) as ToolSet | undefined
const aiSdkTools = convertToolsForAiSdk(metadata?.tools) as ToolSet | undefined

const providerOptions = this.buildProviderOptions(useR1Format)

Expand Down
3 changes: 1 addition & 2 deletions src/api/providers/zai.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ export class ZAiHandler extends BaseProvider implements SingleCompletionHandler

const aiSdkMessages = convertToAiSdkMessages(messages)

const openAiTools = this.convertToolsForOpenAI(metadata?.tools)
const aiSdkTools = convertToolsForAiSdk(openAiTools) as ToolSet | undefined
const aiSdkTools = convertToolsForAiSdk(metadata?.tools) as ToolSet | undefined

const requestOptions: Parameters<typeof streamText>[0] = {
model: languageModel,
Expand Down
Loading