Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/providers/__tests__/openai.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ describe("OpenAiHandler", () => {
],
stream: true,
stream_options: { include_usage: true },
temperature: 0,
temperature: undefined,
tools: undefined,
tool_choice: undefined,
parallel_tool_calls: true,
Expand Down
5 changes: 3 additions & 2 deletions src/api/providers/openai.ts
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl

const requestOptions: OpenAI.Chat.Completions.ChatCompletionCreateParamsStreaming = {
model: modelId,
temperature: this.options.modelTemperature ?? (deepseekReasoner ? DEEP_SEEK_DEFAULT_TEMPERATURE : 0),
temperature:
this.options.modelTemperature ?? (deepseekReasoner ? DEEP_SEEK_DEFAULT_TEMPERATURE : undefined),
messages: convertedMessages,
stream: true as const,
...(isGrokXAI ? {} : { stream_options: { include_usage: true } }),
Expand Down Expand Up @@ -287,7 +288,7 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
modelId: id,
model: info,
settings: this.options,
defaultTemperature: 0,
defaultTemperature: undefined,
})
return { id, info, ...params }
}
Expand Down
11 changes: 11 additions & 0 deletions src/api/transform/__tests__/model-params.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,17 @@ describe("getModelParams", () => {
expect(result.temperature).toBe(0.3)
})

it("should return undefined temperature when defaultTemperature is undefined and no user/model temperature", () => {
const result = getModelParams({
...openaiParams,
settings: {},
model: baseModel,
defaultTemperature: undefined,
})

expect(result.temperature).toBeUndefined()
})

it("should use model maxTokens when available", () => {
const model: ModelInfo = {
...baseModel,
Expand Down
2 changes: 1 addition & 1 deletion src/api/transform/model-params.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ type GetModelParamsOptions<T extends Format> = {
modelId: string
model: ModelInfo
settings: ProviderSettings
defaultTemperature: number
defaultTemperature: number | undefined
}

type BaseModelParams = {
Expand Down
Loading