Updating Sphinx documentation and typing for PyRosettaCluster#646
Open
klimaj wants to merge 142 commits intoRosettaCommons:mainfrom
Open
Updating Sphinx documentation and typing for PyRosettaCluster#646klimaj wants to merge 142 commits intoRosettaCommons:mainfrom
klimaj wants to merge 142 commits intoRosettaCommons:mainfrom
Conversation
…s' or 'task_registry' instance attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds several improvements to the PyRosettaCluster framework (to be merged after #636 for incremental versioning).
Major changes (maintaining runtime functionality)
pyrosetta.distributed.cluster.type_defsmodule for easier maintainability.attrsclasses.pickleandcloudpicklewarnings to relevant docstrings.PackedPoseHasherandsecure_read_pickleto the top-levelpyrosetta.distributed.clusternamespace for easier usability.Minor changes (updating runtime functionality)
dataclassesmodule to use theattrspackage instead. Also package Dask task arguments in a newExtraArgsattrsclass (with slots and typing) instead of a simple dictionary.Poseobjects are identical -> test whether the scientific state of twoPoseobjects are identical.reserve_scoresdecorator.setobjects) and raise exceptions: input PyRosetta protocols, and outputs produced by PyRosetta protocols, must be ordered for reproducibility purposes.Exceptionrather thanBaseException.