You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, there is an existing bug in monetize v1.13.0 introduced by #167 that attempted to implement additional logic for currency parsing discussed in #153.
Currently, there is an existing bug in monetize v1.13.0 ..
Does this bug only affect the Malaysian ringgit (MYR) or are other currencies affected? Thanks.
This affects any currency that is not in Monetize::Parser::CURRENCY_SYMBOLS.values, according to this line in the code.
I've personally run into the aforementioned issue with Malaysian Ringgit (as "RM", not "MYR") and Australian Dollar (AUD) since neither of them are in Monetize::Parser::CURRENCY_SYMBOLS.values.
Monetize::Parser::CURRENCY_SYMBOLS's main purpose seems to be to map non-ISO currency symbols to their respective ISO-4217 currency code. That's why I think it is unsuitable to be used in the manner implemented in #167
What do you think? And thanks for taking a look!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is an existing bug in
monetizev1.13.0 introduced by #167 that attempted to implement additional logic for currency parsing discussed in #153.Example of the bug:
This PR aims to:
Money::Currency.all.map(&:iso_code).spec/monetize_spec.rbto accommodate for the aforementioned changes.