fix: prevent channel shift when appending to an empty keep-alive queue#872
Open
roderickvd wants to merge 1 commit intomasterfrom
Open
fix: prevent channel shift when appending to an empty keep-alive queue#872roderickvd wants to merge 1 commit intomasterfrom
roderickvd wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Player::connect_newcallsmixer.add(queue)with an empty queue,UniformSourceIterator::bootstrap()captureschannels=1from theEmptyplaceholder and creates aTake(1)with aChannelCountConverter(from=1). If a stereo source is then appended before the audio thread callsnext(), that first sample passes through the wrong converter: L is treated as mono and duplicated, permanently shifting the stream by one sample and shifting channels.Supersedes #870
Fixes #871