Update PrimeParams to require a multiplicative generator value#1221
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Mar 9, 2026
Merged
Update PrimeParams to require a multiplicative generator value#1221tarcieri merged 1 commit intoRustCrypto:masterfrom
PrimeParams to require a multiplicative generator value#1221tarcieri merged 1 commit intoRustCrypto:masterfrom
Conversation
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
- Coverage 87.96% 87.94% -0.03%
==========================================
Files 184 184
Lines 21172 21165 -7
==========================================
- Hits 18624 18613 -11
- Misses 2548 2552 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tarcieri
approved these changes
Mar 9, 2026
Member
tarcieri
left a comment
There was a problem hiding this comment.
This is a breaking change, which we technically can't make anymore, though it does seem like a very useful one for elliptic-curve so we can probably get away with one final breaking change and yanking the v0.7.0 release.
(I was thinking about waiting to see if you wanted to make a change like this before releasing v0.7.0, but I guess I jumped the gun)
Contributor
|
Or just release a 0.8? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adjusts the
const_prime_monty_params!macro to accept the new generator parameter. Thetconstant is added toPrimeParamsfor convenience.