Skip to content

Update PrimeParams to require a multiplicative generator value#1221

Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom
andrewwhitehead:fix/prime-gen
Mar 9, 2026
Merged

Update PrimeParams to require a multiplicative generator value#1221
tarcieri merged 1 commit intoRustCrypto:masterfrom
andrewwhitehead:fix/prime-gen

Conversation

@andrewwhitehead
Copy link
Contributor

This also adjusts the const_prime_monty_params! macro to accept the new generator parameter. The t constant is added to PrimeParams for convenience.

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.94%. Comparing base (3c38f48) to head (e9e77e5).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/modular/prime_params.rs 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
- Coverage   87.96%   87.94%   -0.03%     
==========================================
  Files         184      184              
  Lines       21172    21165       -7     
==========================================
- Hits        18624    18613      -11     
- Misses       2548     2552       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, which we technically can't make anymore, though it does seem like a very useful one for elliptic-curve so we can probably get away with one final breaking change and yanking the v0.7.0 release.

(I was thinking about waiting to see if you wanted to make a change like this before releasing v0.7.0, but I guess I jumped the gun)

@tarcieri tarcieri merged commit eb05031 into RustCrypto:master Mar 9, 2026
31 checks passed
@fjarri
Copy link
Contributor

fjarri commented Mar 9, 2026

Or just release a 0.8? :)

@andrewwhitehead andrewwhitehead deleted the fix/prime-gen branch March 9, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants