Merged
Conversation
newpavlov
commented
Jun 19, 2024
| // It is also properly aligned, because `u8` has an alignment of `1`. | ||
| unsafe { | ||
| volatile_set((self as *mut Self).cast::<u8>(), 0, mem::size_of::<Self>()); | ||
| volatile_set((self as *mut Self).cast::<u8>(), 0, size_of::<Self>()); |
Member
Author
There was a problem hiding this comment.
I am not sure why exactly compiler complains about mem::size_of. Was it added to the prelude?
Member
There was a problem hiding this comment.
Yeah, it was. Just encountered that here too: RustCrypto/traits#1589
tarcieri
reviewed
Jun 19, 2024
| #[cfg(feature = "std")] | ||
| impl Zeroize for CString { | ||
| fn zeroize(&mut self) { | ||
| use core::mem; |
Member
There was a problem hiding this comment.
I think you can continue to import mem, or maybe just import take?
Member
Author
There was a problem hiding this comment.
This import would need to be gated on feature = "std", otherwise the compiler will complain about unused import. I think importing it inside the method is the simplest option. IMO mem::take/replace is a bit easier to read than just take/replace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.