Handle PHEV ignore codes for target SOC and scheduled charging#401
Merged
nanomad merged 1 commit intoSAIC-iSmart-API:developfrom Feb 17, 2026
Merged
Conversation
PHEV vehicles (e.g. MG EHS) send 0 for target SOC (P_IGNORE) and scheduled charging mode, which are not valid values. Filter these out early, consistent with how C_IGNORE is already handled for charge current limit. Fixes SAIC-iSmart-API#379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0for target SOC (TargetBatteryCode.P_IGNORE) and scheduled charging mode (bmsReserCtrlDspCmd), which are not valid operational valuesChrgMgmtDataPublisher, consistent with howChargeCurrentLimitCode.C_IGNOREis already handled for charge current limitValueError: Unknown target battery code: TargetBatteryCode.P_IGNOREcrash andValueError: 0 is not a valid ScheduledChargingModeerrorTest plan
Fixes #379