fix: preserve meaningful stop reasons for battery heating and charging#404
Merged
nanomad merged 1 commit intoSAIC-iSmart-API:developfrom Feb 19, 2026
Merged
Conversation
SAIC-iSmart-API#396) The API resets bmsPTCHeatResp and bmsChrgSpRsn back to 0 (NO_REASON) quickly after heating/charging stops. Since the gateway polls periodically, the next poll overwrites the meaningful stop reason with NO_REASON. Skip publishing when the stop reason is NO_REASON so the last meaningful value is preserved as a retained MQTT message. The binary sensors for battery heating and charging status already indicate whether the process is currently active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #396. The API resets
bmsPTCHeatRespandbmsChrgSpRsnback to0(NO_REASON) quickly after heating/charging stops. Since the gateway polls periodically, the next poll overwrites the meaningful stop reason (e.g.REACHED_STOP_TIME,UNNECESSARY) withNO_REASON.Adds a validator to skip publishing when the stop reason is
NO_REASON, so the last meaningful value is preserved as a retained MQTT message. Applies to both:drivetrain/batteryHeatingStopReason(HeatingStopReason.NO_REASON)drivetrain/chargingStopReason(ChargingStopReason.NO_REASON)The binary sensors for battery heating and charging status already indicate whether the process is currently active, so
NO_REASONcarries no useful information.Test plan
REACHED_STOP_TIME) survives across subsequent pollsChrgPtcHeatResp) are still published correctly (separate code path, unchanged)🤖 Generated with Claude Code