Merged
Conversation
beckermarc
reviewed
Feb 1, 2023
beckermarc
reviewed
Mar 3, 2023
beckermarc
reviewed
Mar 17, 2023
beckermarc
approved these changes
Mar 17, 2023
Contributor
beckermarc
left a comment
beckermarc
left a comment
There was a problem hiding this comment.
I made a few more adaptions. I thought it was nicer when we had the instructions what to change in .cdsrc.json directly in README and avoid introducing two new files that need to be maintained as well, when we make changes outside of the requires section of .cdsrc.json.
Hope the changes are fine with you. From my perspective this can be merged now :)
Contributor
Author
|
The changes look good. Thanks @beckermarc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched to Approuter based UI deployment instead of HTML5 Apps based and updated other sections.