Skip to content

Support upcoming Shell event handler update for permission events by …#188

Merged
kistll merged 3 commits intomasterfrom
feature/permission-event-enhancement
Mar 30, 2026
Merged

Support upcoming Shell event handler update for permission events by …#188
kistll merged 3 commits intomasterfrom
feature/permission-event-enhancement

Conversation

@kistll
Copy link
Copy Markdown
Contributor

@kistll kistll commented Mar 30, 2026

…enhancing models, schemas and docs

  • Change model PermissionRequestV3 from interface to type to support multiple permissions at once for event Version3.GET_PERMISSIONS
  • Define new model PermissionRequestV2 to support multiple permissions at once for event Version2.GET_PERMISSIONS
    • So far the events Version2.GET_PERMISSIONS and Version1.GET_PERMISSIONS shared the model PermissionRequest as request payload model. However, as only the event Version2.GET_PERMISSIONS is enhanced the new model is introduced to distinguish the request payload between the two events. The event Version1.GET_PERMISSIONS is not enhanced as it is deprecated.

Copy link
Copy Markdown
Contributor

@zalincaclaudiu zalincaclaudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kistll kistll merged commit a60ba38 into master Mar 30, 2026
4 checks passed
@kistll kistll deleted the feature/permission-event-enhancement branch March 30, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants